Skip to content

refactor: rename class from ProgramStorage to ProgramSaver #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shimomo merged 5 commits into from
Aug 29, 2025
Merged

refactor: rename class from ProgramStorage to ProgramSaver #53

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07d8ee1
refactor: rename class from ProgramStorage to ProgramSaver
shimomo Aug 29, 2025
bc7cf16
refactor: rename variable from $storage to $saver
shimomo Aug 29, 2025
730d82e
refactor: rename tempDir from /program_storage_test to /program_saver…
shimomo Aug 29, 2025
c225e63
refactor: change mkdir permissions from 0777 to 0755 for better security
shimomo Aug 29, 2025
7978523
test: improve collision resistance of temporary directories
shimomo Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scraper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
require __DIR__ . '/vendor/autoload.php';

use BOA\Programs\ProgramScraper;
use BOA\Programs\ProgramStorage;
use BOA\Programs\ProgramSaver;
use BOA\Programs\ScraperAdapter;
use BVP\Scraper\Scraper;
use Carbon\CarbonImmutable as Carbon;
Expand Down Expand Up @@ -34,6 +34,6 @@
// 出走表データを JSON ファイルとして保存
// 日付付きの JSON ファイルとして保存（例: docs/{version}/YYYY/YYYYMMDD.json）
// 最新データとして today.json にも保存
$storage = new ProgramStorage();
$storage->save($programs, "docs/{$version}/" . $date->format('Y') . '/' . $date->format('Ymd') . '.json');
$storage->save($programs, "docs/{$version}/today.json");
$saver = new ProgramSaver();
$saver->save($programs, "docs/{$version}/" . $date->format('Y') . '/' . $date->format('Ymd') . '.json');
$saver->save($programs, "docs/{$version}/today.json");
2 changes: 1 addition & 1 deletion src/ProgramStorage.php → src/ProgramSaver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*
* @author shimomo
*/
final class ProgramStorage
final class ProgramSaver
{
/**
* @psalm-param ScrapedStadiumRaces $programs
Expand Down
10 changes: 5 additions & 5 deletions tests/ProgramStorageTest.php → tests/ProgramSaverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

namespace BOA\Programs\Tests;

use BOA\Programs\ProgramStorage;
use BOA\Programs\ProgramSaver;
use PHPUnit\Framework\TestCase;

/**
* @author shimomo
*/
final class ProgramStorageTest extends TestCase
final class ProgramSaverTest extends TestCase
{
/**
* @psalm-var non-empty-string
Expand All @@ -27,7 +27,7 @@ final class ProgramStorageTest extends TestCase
protected function setUp(): void
{
parent::setUp();
$this->tempDir = sys_get_temp_dir() . '/program_storage_test_' . uniqid();
$this->tempDir = sys_get_temp_dir() . '/program_saver_test_' . uniqid();
mkdir($this->tempDir, 0777, true);
}

Expand Down Expand Up @@ -59,7 +59,7 @@ protected function tearDown(): void
*/
public function testSave(): void
{
$storage = new ProgramStorage();
$saver = new ProgramSaver();
$path = $this->tempDir . '/programs.json';

$programs = [
Expand Down Expand Up @@ -102,7 +102,7 @@ public function testSave(): void
],
];

$storage->save($programs, $path);
$saver->save($programs, $path);

$this->assertFileExists($path);

Expand Down