Open
Conversation
Contributor
Author
|
Not sure why the CI failed, on my repo it worked. |
Bodigrim
reviewed
Apr 8, 2025
| prop_jacobi_de :: Rational -> Rational -> Property | ||
| prop_jacobi_de a b = foldl' (.&&.) (property True) $ | ||
| prop_jacobi_de :: NonNegative Rational -> NonNegative Rational -> Property | ||
| prop_jacobi_de (NonNegative a) (NonNegative b) = foldl' (.&&.) (property True) $ |
Owner
There was a problem hiding this comment.
Jacobi polynomials are defined for negative arguments, but our implementation is faulty. When a+b is integer, one can probably directly compute via the second formula at https://en.wikipedia.org/wiki/Jacobi_polynomials#Via_the_hypergeometric_function - two gamma functions degenerate to factorials and the ratio of other two is a Pochhammer symbol.
Bodigrim
reviewed
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.
There were some cases where division by zero could occur. I believe the reason these cases weren't triggered before is that older
QuickCheckversions had a worseArbitrary Rationalinstance.