Skip to content

Conversation

@ToniRos
Copy link
Contributor

@ToniRos ToniRos commented Jan 16, 2026

Solution to conversión from PDF to DOCX reported in issue #425
The quotation marks in the infilter that caused problems with execfile have been removed, and the writer_pdf_import filter has been enabled.


Summary by cubic

Fixes PDF input conversions (e.g., PDF to DOCX/TXT) by enabling the LibreOffice writer_pdf_import filter and removing quotes around --infilter to prevent execFile errors; also avoids filters when exporting to PDF. Addresses issue #425.

Written for commit 3ed9fab. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/converters/libreoffice.ts">

<violation number="1" location="src/converters/libreoffice.ts:105">
P2: PDF export now uses the PDF import filter (`writer_pdf_import`) because the shared map is used for both in/out filters, causing `--convert-to pdf:writer_pdf_import` instead of a PDF export filter.</violation>
</file>

Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Ask questions if you need clarification on any suggestion

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@C4illin C4illin changed the title Fix to issue #425 PDF to DOCX using LibreOffice, fixes #425 Jan 26, 2026
Copy link
Owner

@C4illin C4illin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

ToniRos and others added 3 commits January 26, 2026 22:49
Thanks

Co-authored-by: Emrik Östling <emrik.ostling@gmail.com>
Thanks

Co-authored-by: Emrik Östling <emrik.ostling@gmail.com>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/converters/libreoffice.ts">

<violation number="1" location="src/converters/libreoffice.ts:153">
P2: `--infilter` argument is now a plain string literal, so `${inFilter}` is not interpolated and LibreOffice receives an invalid filter name.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@C4illin C4illin merged commit 52af8d5 into C4illin:main Jan 29, 2026
7 checks passed
evil9369 pushed a commit to pi-docket/ConvertX-CN that referenced this pull request Feb 1, 2026
Merged changes:
- chore: update eslint config (C4illin#521)
- PDF to DOCX using LibreOffice, fixes C4illin#425 (C4illin#510)
- chore: update deps (C4illin#522)
- chore(deps): eslint-plugin-better-tailwindcss to v4 (C4illin#506)

Conflict resolution:
- package.json: keep our @sinclair/typebox, upgrade eslint-plugin to v4
- eslint.config.ts: keep our extended ignores
- libreoffice.ts: keep our PDF import pipeline (more complete)
- root.tsx, history.tsx: keep our Chinese localized version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants