-
Notifications
You must be signed in to change notification settings - Fork 155
feat:Add Deleted status option to filter drawer UI #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat:Add Deleted status option to filter drawer UI #549
Conversation
|
should not add toggle instead add new option of deleted in the same ui |
|
i will do that just a moment |
|
@SGI-CAPP-AT2 i add the delete option same like pending, complete instead of toggle check it once |
update PR description image |
|
@Prashik-Sasane , This should also work when profile server is changed to CCSync or Taskchampion |
|
@SGI-CAPP-AT2 now if any errors just let me knows |
|
@Prashik-Sasane
|
|
Also note that we have deprecated ccsync profile, You can remove ccsync logic from the pr |
SGI-CAPP-AT2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer above comments !
…flutter into feature/deleted-status-filter
ok i will do that and update PR with description |
|
@SGI-CAPP-AT2 Could you check latest commit changes? and, its works for taskserver as 3 filter status (pending , deleted , completed) and for taskchampion/taskreplica as 2 filter status (pending, completed). |
|
Can you add tags filter for Taskchampion (v3) which is currently missing? Also we are missing auto apply project filter, which does not populate tasks in v2, v3? |
ok i will do that so i need to push in this branch or new PR and also can you check this branch changes like it correct or not |
If you want to do, do it in this PR do not open new PR |
|
@SGI-CAPP-AT2 i add the tag filter for taskchampion (V3) first check it on your side like whether its correct or not and also i faced the issue like now in my side when i create one task in taskserver and add tag something then i select taskchampion it also reflects taskchampion tag filter example like ( tag:- abcd) it show for both could you give any suggestion? |
|
@SGI-CAPP-AT2 hey i am not able to solve this auto filter problems #576 can you assign to someone and also in this branch everything workings well can you check it and merge the code |
Ok NP |


Description
You can check the issue after clicking on the issue number (#482), and this PR fixes the issue when tasks are deleted. Then, it shows into a completed filter, and I add the deleted filter status option in UI, but it works fine for Taskserver, and when for taskchampion/taskReplica delete filter status option does not work, so I remove the deleted filter for the taskchampion server.
And i also add the tag filter for taskchampion/taskReplica(V3) server means we can also filter out the task by tags in taskchampion like in taskserver. initially tag filter logic and visibility is missing so i fullfilled that part.
videos ( current behaviour)
taskchampion.mp4
new changes ( Taskchampion tags filter)
Future improvement
Checklist