Feature/loop for crashed tasks#266
Feature/loop for crashed tasks#266rakovskij-stanislav wants to merge 8 commits intoCERT-Polska:masterfrom
Conversation
|
@psrok1 Hello! Just a gentle ping regarding this PR) |
…kState.CRASHED to karton.py
|
Hello! Thanks for the contribution and sorry for very late answer. We had some internal discussions about this PR and then it was put on the shelf. I don't think that this method should be a part of If we add something to one of the main Karton classes, we also set a contract that we will not break it in future versions. This feature looks like something really difficult to maintain and it's possible that we're going to add much more points to that list in the future 😃 We thought about implementing it in a different way, but right now we don't have any ideas. I would make an issue on that problem and maybe someone will come with less hacky way to implement such utility. |
Karton already supports debug mode, but sometimes you need to works with already "unwealthy" tasks that crashed.
Restarting them is not an option - you cannot predict which consumer will get this task, while you need to feed this task to exact consumer you run under debugger / with extra prints / etc. The goal is to debug crashed task without interrupting the processing.
This PR introduces new method,
Consumer.loop_crached_tasksthat gradually makes debugging process more easy by working only with crashed tasks. It has several restrictions:karton.tasksinstead ofkarton.queuelist in redis.CRASHEDmetrics on further crashes.STARTED.