-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Ss2 do intersect efif #9303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
efifogel
wants to merge
27
commits into
CGAL:main
Choose a base branch
from
efifogel:Ss2-do_intersect-efif
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111,225
−2,332
Open
Ss2 do intersect efif #9303
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
94d0e5b
Introduced Do_intersect_surface_sweep_2
efifogel ae33c8d
Clean implementation of Surface_sweep_2::do_intersect
efifogel 5bdda0a
add missing license
sloriot 98a924c
missing license
sloriot 25373ec
trailing whitespaces
sloriot dc64fdb
remove tmp files
sloriot 670d6d9
Apply suggestion from @afabri
afabri 8615bcb
Added missing return type
efifogel a328685
Replaced "closed" with "consider_end_points"
efifogel ba038c6
Apply suggestion from @afabri
afabri f22869a
Changed names of parameters from "closed" => "consider_common_endpoin…
efifogel d74aa6d
Merge branch 'Ss2-do_intersect-efif' of github.com:efifogel/cgal into…
efifogel 92d79bd
Fixed name of concept (Make_x_monotone_2 => AosTraits::MakeXMonotone_2)
efifogel b487bb3
Added missing backticks
efifogel 541fd11
Removed requirement of "Core"
efifogel 79897d0
Fixed typo in name of variable
efifogel 150b457
fix warnings
sloriot da31850
fix compilation error
sloriot 9e15f5a
Removed unused variable
efifogel b0ee78a
Removed redundant do_intersect() functions and renamed to reduce over…
efifogel 5959247
Merge branch 'main' into Ss2-do_intersect-efif
efifogel ab49394
Fixed backticks of `true` and `false`
efifogel c396a7e
fix warning
sloriot 01b3362
add missing include directions
sloriot 19452b5
fix compilation issues detected by the CI
sloriot b43bbb6
fix dependencies
sloriot d7c7fb5
Fixed typo
efifogel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
Arrangement_on_surface_2/benchmark/Arrangement_on_surface_2/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| cmake_minimum_required(VERSION 3.12...3.31) | ||
| project(do_intersect) | ||
| find_package(Boost CONFIG ${BOOST_MIN_VERSION} REQUIRED COMPONENTS program_options) | ||
| find_package(CGAL REQUIRED COMPONENTS Core OPTIONAL_COMPONENTS Qt6) | ||
| add_executable(do_intersect do_intersect.cpp) | ||
| target_link_libraries(do_intersect PRIVATE CGAL::CGAL CGAL::CGAL_Qt6 CGAL::CGAL_Basic_viewer Boost::program_options) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because Core is no longer conditional