Linter small talk #121
Merged
Linter small talk #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the layout from other functions
Also fix the type errors on the functions calling it, and add a unit test to check it works
This could cause a race condition if we don't check before the `try`
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
EdGeraghty
force-pushed
the
linter-small-talk
branch
from
13fc45e to
6caba5f
Compare
Session creation will stacktrace if unable to create, appease the linter by casting our session so it doesn't think it's `None`
Contributor
|
@EdGeraghty I've opened a new pull request, #122, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
|
@EdGeraghty I've opened a new pull request, #123, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: EdGeraghty <20861699+EdGeraghty@users.noreply.github.com>
Acknowledge contradictory feedback on redundant runtime checks
Remove backticks from docstring parameters to follow Python conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving type safety, error handling, and code clarity in both the command handling and Semaphore integration modules. The changes ensure that functions consistently handle optional parameters, and introduces a new method for retrieving individual task details from Semaphore.
New functionality:
get_taskinchatrixcd/semaphore.pyto retrieve details of a specific task by its ID, including error handling for session initialization and request failures.These changes collectively improve the maintainability, reliability, and clarity of the codebase, especially in scenarios where optional parameters or external dependencies (like network sessions) may be absent or fail.