Skip to content

BCDA-8987-uncomment-tests#1205

Merged
bhagatparwinder merged 3 commits intomainfrom
parwinder/BCDA-8987-reinstate-tests
Sep 4, 2025
Merged

BCDA-8987-uncomment-tests#1205
bhagatparwinder merged 3 commits intomainfrom
parwinder/BCDA-8987-reinstate-tests

Conversation

@bhagatparwinder
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8987

🛠 Changes

  • Reinstate TestDenyACOs_Integration

ℹ️ Context

  • To use the river queue's test helpers, a pgx upgrade was required. These updates have caused tests to fail.
  • PGX 5.7.1 was the previous version that did not have any issues—upgrading to any version past that introduces these errors, particularly with the lambda integration test. Since no updates are planned for the ACO Deny Lambda, we can safely allow this test to fail while we determine a fix.
  • The lambda test is failing because there seems to have been a known issue in 5.7.2+ when trying to scan a nil *struct, which is what the test is doing.
  • This is a known issue that was addressed here and fixed here

🧪 Validation

Local lint, build and test

@bhagatparwinder bhagatparwinder marked this pull request as ready for review September 4, 2025 18:05
@bhagatparwinder bhagatparwinder requested a review from a team as a code owner September 4, 2025 18:05
@bhagatparwinder bhagatparwinder merged commit f4935b8 into main Sep 4, 2025
8 checks passed
@bhagatparwinder bhagatparwinder deleted the parwinder/BCDA-8987-reinstate-tests branch September 4, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants