DPC-5127 update portal to use multiple OIDC#2883
DPC-5127 update portal to use multiple OIDC#2883jdettmannnava wants to merge 29 commits intomainfrom
Conversation
… into jd/dpc-5127-multiple-oidc
| # and recreated between test runs. Don't rely on the data there! | ||
|
|
||
| Rails.application.configure do | ||
| config.colorize_logging = false |
There was a problem hiding this comment.
probably don't need to change this config setting
There was a problem hiding this comment.
Not necessary, but I found that it was difficult to analyze the logs because of their colorization, so I would prefer to leave this change in.
There was a problem hiding this comment.
I'm wondering if this .find_or_create_by() needs to be updated to include login_dot_gov
e.g.
@user = User.find_or_create_by!(provider: :login_dot_gov, uid: user_info['sub']) do |user_to_create|
There was a problem hiding this comment.
Yup, this needs to change
|
✅ updated redirects look good Only open question I have is - does this capture intended behavior for provider column for newly created users? |
|
I confirmed that provider is set correctly for new users! Thanks for updating! 
|
MEspositoE14s
left a comment
MEspositoE14s
left a comment
There was a problem hiding this comment.
Makes sense to me!
3 participants
NOT FOR MERGE UNTIL CMS APPROVAL
🎫 Ticket
https://jira.cms.gov/browse/DPC-5127
🛠 Changes
ℹ️ Context
We are moving to a multi-IDP environment. These IDPs use the OIDC protocol. Because of complexity, the Devise authentication gem only supports one openid_connect provider via the omniauth_openid_connect gem. Fortunately, we use very little Devise functionality, so removing the gem and replacing the necessary parts was not very extensive.
🧪 Validation
Automated tests updated to handle a world without devise.
Successfully logged in and out from localhost.
Successfully failed invitation flow.
Successfully passed invitation flow.
Post-Deploy Actions
After deployment, the following SQL will need to run in dpc-portal. This should not be a problem, as we are not in upper environments.
UPDATE users set provider = 'login_dot_gov';