Conversation
Member
Author
|
Don't merge yet, still need to test this with communities of enzyme models in DiffMet |
exaexa
requested changes
Jan 4, 2025
Member
Author
|
Not sure why still failing |
Member
|
Looks like issues with subtyping, gonna fix it. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 38 +2
Lines 584 573 -11
=========================================
- Hits 584 573 -11 ☔ View full report in Codecov by Sentry. |
exaexa
force-pushed
the
sew-generalize-enzymes
branch
from
f5fe968 to
5f9fe21
Compare
exaexa
approved these changes
Jan 7, 2025
Member
exaexa
left a comment
exaexa
left a comment
There was a problem hiding this comment.
also caused COBREXA/ConstraintTrees.jl#65
once the CI passes this should be hopefully okay
stelmo
commented
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a more general IsozymeT and modifies some enzyme specific methods to be general (not float specific)