Skip to content

Comments

Make total bounds based on genes in model, not on argument to function#83

Closed
stelmo wants to merge 1 commit intomasterfrom
sew-simplify-enzymes
Closed

Make total bounds based on genes in model, not on argument to function#83
stelmo wants to merge 1 commit intomasterfrom
sew-simplify-enzymes

Conversation

@stelmo
Copy link
Member

@stelmo stelmo commented Jan 6, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ed2e260) to head (6b9a566).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          584       584           
=========================================
  Hits           584       584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stelmo stelmo changed the title Various optimizations for enzyme based models Make total bounds based on genes in model, not on argument to function Jan 6, 2025
@stelmo stelmo requested a review from exaexa January 6, 2025 13:20
@exaexa
Copy link
Member

exaexa commented Jan 6, 2025

I think this is solved by hte haskey in here already https://github.com/COBREXA/COBREXA.jl/blob/master/src/builders/enzymes.jl#L219

(please doublecheck)

@stelmo stelmo closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants