Conversation
yash-yp
left a comment
yash-yp
left a comment
There was a problem hiding this comment.
Good attempt!
I have addressed a few concerns in the comments
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Read the use of .gitignore to prevent commiting unwanted files
components/addTask.vue
Outdated
| <label for="add task" class="flex-1"> | ||
| <input | ||
| type="text" | ||
| v-model="taskadded" |
There was a problem hiding this comment.
Read about using the right name convention for Javascript
| <main class="max-w-lg mx-auto px-6"> | ||
| <add-task @newTask="getTasks" /> | ||
| <transition> | ||
| <transition name="slide-fade"> |
There was a problem hiding this comment.
You can also use transition groups to apply the effect to each list element
There was a problem hiding this comment.
I have now applied transition to individual todos but it works only when todo is deleted. When todo is added this transition is not applied because getTask function is called for getting the entire list of todos.
middleware/auth.ts
Outdated
|
|
||
| const location = context.route.fullPath | ||
| const token = context.store.getters.token | ||
| console.log(location) |
There was a problem hiding this comment.
Remove all console.log() after done debugging
|
|
||
| updateTask(_index, _id) { | ||
|
|
||
| this.todos[_index].editing = !this.todos[_index].editing |
There was a problem hiding this comment.
A better way to edit would have been to fill edit space with the pre-existing task
pages/login/index.vue
Outdated
| state.username === '' || | ||
| state.password === '' | ||
| ) { | ||
| $toast.error('Please enter correct login credentials.') |
There was a problem hiding this comment.
Providing feedback to user about error will be better ie username/password cannot be empty
2 participants
Tasks:
Deployment link