Skip to content

Fix file rotation failure in offline storage #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quzn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix file rotation failure in offline storage #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/offlinelogstorage/dlt_offline_logstorage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,6 +1760,7 @@ DLT_STATIC int dlt_daemon_offline_setup_filter_properties(DltLogStorage *handle,
tmp_data.log_level = DLT_LOG_VERBOSE;
tmp_data.reset_log_level = DLT_LOG_OFF;
tmp_data.disable_network_routing = DLT_LOGSTORAGE_DISABLE_NW_OFF;
tmp_data.fd = -1;

for (i = 0; i < DLT_LOGSTORAGE_FILTER_CONF_COUNT; i++) {
ret = dlt_logstorage_get_filter_value(config_file, sec_name, i, value);
Expand Down
3 changes: 2 additions & 1 deletion src/offlinelogstorage/dlt_offline_logstorage_behavior.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,8 @@ int dlt_logstorage_open_log_file(DltLogStorageFilterConfig *config,
* is_sync is true and (other than ON_MSG sync behavior and current size is less than configured size) or
* msg_size fit into the size (ON_MSG or par of cache needs to be written into new file), open it */
if ((ret == 0) &&
((is_sync && (s.st_size < (int)config->file_size)) ||
((config->fd == -1) ||
(is_sync && (s.st_size < (int)config->file_size)) ||
(!is_sync && (s.st_size + msg_size <= (int)config->file_size)))) {
dlt_logstorage_open_log_output_file(config, absolute_file_path, "a");
config->current_write_file_offset = s.st_size;
Expand Down