Added code for Confirmation Prompt when running qse clear#97
Merged
Ashrockzzz2003 merged 7 commits intoCSE-25:mainfrom Jan 22, 2025
Merged
Added code for Confirmation Prompt when running qse clear#97Ashrockzzz2003 merged 7 commits intoCSE-25:mainfrom
Ashrockzzz2003 merged 7 commits intoCSE-25:mainfrom
Conversation
Ashrockzzz2003
requested changes
Jan 19, 2025
Member
Ashrockzzz2003
left a comment
Ashrockzzz2003
left a comment
There was a problem hiding this comment.
I modified the UX of the command in console. Can you please move the logic of clear commad to bin/util/clear.js. We're trying to modularize the codebase. The menu and docker options are already modularized. Let this also be.
Contributor
Author
|
The UX changes look good. I'll work on moving clear command logic to |
Contributor
Author
|
@Ashrockzzz2003 I have moved the clear command logic to a seperate |
Ashrockzzz2003
approved these changes
Jan 22, 2025
Member
Ashrockzzz2003
left a comment
Ashrockzzz2003
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the contribution @adithya-menon-r
Member
|
/bounty 30 @adithya-menon-r |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #94.
I have used the inquirer package as in #85 to prompt the user for confirmation when running
qse clear. If the user confirms, the process continues and the project dir is cleared, else it cancels the operation.@Ashrockzzz2003 Please review it and let me know if I have to make any changes. Thank You!