Skip to content

Comments

Optimize performance of key bulk deletion#1287

Merged
lubomirw merged 3 commits intoCZERTAINLY:mainfrom
ivosh:perf-key-bulk-delete
Feb 19, 2026
Merged

Optimize performance of key bulk deletion#1287
lubomirw merged 3 commits intoCZERTAINLY:mainfrom
ivosh:perf-key-bulk-delete

Conversation

@ivosh
Copy link
Collaborator

@ivosh ivosh commented Feb 18, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 18, 2026 09:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request optimizes the performance of cryptographic key bulk deletion operations by implementing batch processing with manual transaction management. The changes enable efficient deletion of large numbers of key items while maintaining proper security filtering and permission evaluation.

Changes:

  • Implemented batch processing for key item deletion with configurable batch size
  • Added support for multiple parent resource security filtering (TokenInstance and TokenProfile)
  • Introduced bulk operations for clearing certificate key associations
  • Enhanced test coverage with bulk deletion and permission evaluation tests

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
CryptographicKeyServiceImpl.java Main implementation of batch deletion logic with manual transaction management and dual-parent security filtering
CryptographicKeyService.java Updated interface to accept SecurityFilter parameter for bulk deletion
CryptographicKeyControllerImpl.java Updated controller to pass SecurityFilter to service method
ObjectFilterAspect.java Extracted populateSecurityFilter as public method for manual security filter population
CryptographicKeyItemRepository.java Added findWithKeyByUuidIn method for efficient key item fetching with associated keys
CertificateRepository.java Added bulk operations for clearing key associations
CertificateService.java Added bulkClearKeyAssociations interface method
CertificateServiceImpl.java Implemented bulk clear operations and optimized single clear operation
CryptographicKeyServiceTest.java Added comprehensive tests for bulk deletion and permission evaluation scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivosh ivosh self-assigned this Feb 18, 2026
@ivosh ivosh added the performance Refactor or fix code to improve performance label Feb 18, 2026
@ivosh ivosh added this to CZERTAINLY Feb 18, 2026
@ivosh ivosh linked an issue Feb 18, 2026 that may be closed by this pull request
@ivosh ivosh requested a review from Copilot February 18, 2026 10:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivosh
Copy link
Collaborator Author

ivosh commented Feb 18, 2026

@lubomirw Please could you have a look. The build and code analysis fails because of repeated problems with database connectivity.

@ivosh ivosh requested a review from lubomirw February 18, 2026 11:01
@ivosh ivosh moved this from Open to Code Review in CZERTAINLY Feb 18, 2026
@ivosh ivosh force-pushed the perf-key-bulk-delete branch from 36e209e to 16685d0 Compare February 19, 2026 12:37
@sonarqubecloud
Copy link

@lubomirw lubomirw merged commit 805ca8b into CZERTAINLY:main Feb 19, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Code Review to Ready for testing in CZERTAINLY Feb 19, 2026
@lubomirw lubomirw changed the title Optimize performance of key bulk deletion (#1280) Optimize performance of key bulk deletion Feb 19, 2026
@ivosh ivosh deleted the perf-key-bulk-delete branch February 19, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Refactor or fix code to improve performance

Projects

Status: Ready for testing

Development

Successfully merging this pull request may close these issues.

Improve performance of key bulk deletion

2 participants