Define a simpler PenguinDataset in Exercise 1 notebook#73
Merged
Conversation
Member
Author
|
@jatkinson1000 would you prefer the jupyter notebook outputs to be retained? |
bb826e4 to
a0b7f55
Compare
Member
Author
|
Jack confirmed that we should retain the cell outputs of the solutions notebook for reference. |
…taset defined within the notebook itself
…n optional exercise
4aed474 to
da3e1ae
Compare
Member
jatkinson1000
left a comment
There was a problem hiding this comment.
This all looks sensible to me in theory @ma595
Caveat that I have not run the code and will leave this (and approval) to @surbhigoel77 as the co-presenter.
I agree that it would be easier to move changes to the colab branch after merging to main.
Also consider how other exercises might need adapting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a simpler
PenguinDatasetwithin theworked-solutions/01_penguin_classification_solutions.ipynbnotebook.Within this easier PenguinDataset we:
_load_penguin_data(...)and_split_data(...)into__init__()lambdasandComposeobject, making it easier to follow.Other notebook changes include:
_penguins.pyhas been referenced in the notebook as an example of good software practice.Composehas been removed.Before merging, the following tasks must be completed:
Propagate changes to:
Closes #71