Skip to content

Revert dataset#99

Closed
ma595 wants to merge 8 commits intomainfrom
revert-dataset
Closed

Revert dataset#99
ma595 wants to merge 8 commits intomainfrom
revert-dataset

Conversation

@ma595
Copy link
Member

@ma595 ma595 commented Jul 8, 2025

To be squashed and merged into #98. This PR reverts the dataset implementation to make the tasks flow better. It avoids a complete restructure of the tasks after #96.

ma595 added 8 commits July 6, 2025 13:34
The hidden cells are added in 01 to improve the flow. The notebook
a little text-heavy.

Address review comments and fix formatting

- Fix a few more typos
- Remove <details> tag in Dataset class markdown description. Add
ellipsis
- Rework the CrossEntropyLoss description as an alternative to BCELoss
- Move the Resnet example up a few cells so it flows better with the
network exercise
- Remove hint for the iterate over features exercise
- Remove comment about activation function not being in the network

Make initial changes to move to CrossEntropyLoss

Convert notebook 1 to work with CrossEntropyLoss

Modified link and changed comment to CELoss

Replace BCE with CrossEntropy in exercise

Modify content on Softmax in Task 9.

It's not necessary to use softmax in the notebook as it's
already included in the PyTorch implementation. Add a bit more
explanation about this in the notebook.

Add note on excluding activation from model

Inital fix to CrossEntropy in 03

Fix eye typos

Add executed 03

Update Resnet50 name, add note in task 9

Pylance fixes and run 01 solution
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

ma595 added a commit that referenced this pull request Jul 8, 2025
ma595 added a commit that referenced this pull request Jul 8, 2025
@ma595 ma595 closed this Jul 8, 2025
@ma595 ma595 deleted the revert-dataset branch July 8, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant