-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: implement cap deep links and raycast extension #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d3vv3r
wants to merge
5
commits into
CapSoftware:main
Choose a base branch
from
d3vv3r:feat/deep-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+726
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, script portability)
This commit includes:\n- Balanced Media Foundation/COM initialization via ThreadInitGuard\n- Fixed GPU adapter mismatch defaulting to WARP on Windows\n- Optimized YUV converter to use shared pipelines\n- Fixed various type mismatches and syntax errors in recording pipelines
Author
|
I've implemented several stability fixes for the Windows recording pipeline:
Verification was successful on Windows, showing consistent recording starts and saves without the previous instability. A proof of verification video is available. display.mp4Closes #1540 |
apps/desktop/recordings-from-AppData-Roaming/so.cap.desktop.dev/.window-state.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1540
Greptile Overview
Greptile Summary
This PR implements Cap deep link support and a Raycast extension for controlling recordings via keyboard shortcuts. The implementation adds a new
cap://URL scheme that enables external applications to control Cap's recording functionality.Key changes:
StartDefaultRecording,PauseRecording,ResumeRecording, andStopRecordingtodeeplink_actions.rscap://URL scheme in Tauri configuration alongside the existingcap-desktop://schemecap://scheme first before falling back to the existing action-based parsingRecordingEvent::PausedandRecordingEvent::Resumedevents to update the UIImplementation quality:
The Rust implementation follows repository conventions with proper error handling and async patterns. The pause/resume handlers correctly access the current recording state and emit the appropriate events. The
StartDefaultRecordingaction provides a sensible default (first display, Studio mode, system audio enabled) for quick recording starts.Confidence Score: 5/5
Important Files Changed
cap://URL scheme alongside existingcap-desktop://scheme for deep linkscap://recorddeep link to trigger default recording startcap://stopdeep link to stop active recordingcap://pausedeep link to pause active recordingcap://resumedeep link to resume paused recordingSequence Diagram
sequenceDiagram participant Raycast as Raycast Extension participant OS as Operating System participant Tauri as Tauri Deep Link Handler participant Parser as DeepLinkAction Parser participant App as Cap Desktop App participant Recording as Recording Module participant Frontend as Desktop Frontend Raycast->>OS: open("cap://record") OS->>Tauri: Route cap:// URL Tauri->>Parser: Parse URL to DeepLinkAction Parser->>Parser: Match domain (record/stop/pause/resume) Parser-->>Tauri: Return DeepLinkAction variant Tauri->>App: execute(StartDefaultRecording) App->>Recording: list_displays() Recording-->>App: Display list App->>App: Select first display App->>Recording: start_recording(inputs) Recording-->>App: Recording started Note over Raycast,Frontend: Pause Flow Raycast->>OS: open("cap://pause") OS->>Tauri: Route cap:// URL Tauri->>Parser: Parse URL Parser-->>Tauri: DeepLinkAction::PauseRecording Tauri->>App: execute(PauseRecording) App->>Recording: recording.pause() Recording-->>App: Ok() App->>Frontend: RecordingEvent::Paused.emit() Note over Raycast,Frontend: Resume Flow Raycast->>OS: open("cap://resume") OS->>Tauri: Route cap:// URL Tauri->>Parser: Parse URL Parser-->>Tauri: DeepLinkAction::ResumeRecording Tauri->>App: execute(ResumeRecording) App->>Recording: recording.resume() Recording-->>App: Ok() App->>Frontend: RecordingEvent::Resumed.emit() Note over Raycast,Frontend: Stop Flow Raycast->>OS: open("cap://stop") OS->>Tauri: Route cap:// URL Tauri->>Parser: Parse URL Parser-->>Tauri: DeepLinkAction::StopRecording Tauri->>App: execute(StopRecording) App->>Recording: stop_recording() Recording-->>App: Recording stopped(2/5) Greptile learns from your feedback when you react with thumbs up/down!
Bounty Claim
/claim #1540
Walkthrough
I have implemented the deep link support and Raycast extension as requested.