Open
Conversation
anshk8
reviewed
Oct 21, 2023
Comment on lines
+31
to
+34
| ## Example Code | ||
|
|
||
| ```python | ||
| function generateOrderedList(list l): |
Collaborator
There was a problem hiding this comment.
Cool question! Maybe provide some more sample code to make the solution more doable for beginners
marceljc3
reviewed
Oct 21, 2023
| ```python | ||
| function generateOrderedList(list l): | ||
| >>> | ||
| ``` No newline at end of file |
Collaborator
There was a problem hiding this comment.
Looks good! Could also be an interesting question when it comes to learning about objects/classes (e.g ordering the y-val then outputting the ordered x-vals or something like that)
djoga24
reviewed
Oct 21, 2023
| ## Example Code | ||
|
|
||
| ```python | ||
| function generateOrderedList(list l): |
Collaborator
There was a problem hiding this comment.
LGTM. But, as others have suggested, maybe you could've added a sample solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.