Skip to content

Conversation

@akaladarshi
Copy link
Collaborator

@akaladarshi akaladarshi commented Feb 4, 2026

Summary of changes

Changes introduced in this pull request:

  • Added the snap files generated through:
    • cargo test --lib -- --exact 'rpc::tests::openrpc'
    • cargo insta review
  • Files:
    • forest__rpc__tests__rpc__v0.snap
    • forest__rpc__tests__rpc__v1.snap
    • forest__rpc__tests__rpc__v2.snap

Reference issue to close (if applicable)

Closes #6111

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests
    • Expanded OpenRPC specification test coverage to include additional API paths with updated testing assertions.

@akaladarshi akaladarshi requested a review from a team as a code owner February 4, 2026 09:29
@akaladarshi akaladarshi requested review from hanabi1224 and sudo-shashank and removed request for a team February 4, 2026 09:29
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Walkthrough

Re-enables the previously ignored openrpc snapshot test by removing the ignore attribute and expands test coverage to include ApiPaths::V2, updating snapshot assertions to validate OpenRPC specifications across API versions.

Changes

Cohort / File(s) Summary
OpenRPC Test Enablement
src/rpc/mod.rs
Removed #[ignore] attribute from openrpc test, added ApiPaths::V2 to tested paths, and updated snapshot assertion to insta::assert_yaml_snapshot!(path.path(), spec) for per-version validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

RPC

Suggested reviewers

  • hanabi1224
  • sudo-shashank
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: add open rpc snap files' is partially related to the changeset; it refers to snapshot file addition but misses the primary change of re-enabling the openrpc test.
Linked Issues check ✅ Passed The pull request meets the completion criteria from issue #6111: removes the #[ignore] attribute and snapshot files are generated and committed for testing.
Out of Scope Changes check ✅ Passed All code changes are directly related to re-enabling the openrpc test and generating required snapshot files per issue #6111; no out-of-scope changes detected.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch akaladarshi/add-openrpc-snaps

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2026
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable openrpc snapshot tests

3 participants