Fetching products in collections, custom collections, and smart collections

[kennethjor]

• Added support for fetching products in collections.
• Added support for fetching single custom collections.
• Added support for fetching single smart collections.

[kennethjor]

I have not added any testing right now, which I will do later. The setup doesn't immediately make sense to me.

If there are any comments on the implementation itself, I'm all ears :)

[rjdavis3]

Thanks for your submission @kennethjor. We definitely are requiring unit tests. You can take a look at our Contribution Guide for help with this. If you have any specific questions on testing let us know.

https://github.com/ChannelApe/shopify-sdk/blob/master/CONTRIBUTING.md

Sorry for the delay in responding. We will review your source code around collections soon and provide feedback.

[kennethjor]

@rjdavis3 Well, almost exactly a year later and I finally got around to adding the tests, and fix a bug that they uncovered!

[jspyth]

i need the function, please to merge it

[ryankazokas]

@kennethjor sorry to take a while on this, but we are doing merging. Would you be able to just revert the pitesthistory file on your branch and i will merge this in

[jspyth]

it is ok.i haved solved the problem.

…

---- Replied Message ---- | From | Ryan ***@***.***> | | Date | 06/25/2022 00:41 | | To | ***@***.***> | | Cc | ***@***.******@***.***> | | Subject | Re: [ChannelApe/shopify-sdk] Fetching products in collections, custom collections, and smart collections (#42) | @kennethjor sorry to take a while on this, but we are doing merging. Would you be able to just revert the pitesthistory file on your branch and i will merge this in — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>