Open
Conversation
Contributor
Author
|
I think this is it. I think this might also fix #47 |
Contributor
Author
|
tests pass. |
Contributor
Author
|
ok had a quick look and it seems it doesn't fix #47. i'll look into that one now. |
Contributor
Author
|
ok this branch is ready for merge is your review is positive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a condition is say only repeated every other run, we end up with design matrices with all zeros on the column for that condition on the run it wasn't presented.
This will trigger an error in 2 of our core functions fit_runs and make_project_matrix.
This PR intends to fix this.