feat: Add logicAddress allowlist security mechanism (SynthLaunch implementation)#22
Open
V-SK wants to merge 1 commit intoChatAndBuild:mainfrom
Open
feat: Add logicAddress allowlist security mechanism (SynthLaunch implementation)#22V-SK wants to merge 1 commit intoChatAndBuild:mainfrom
V-SK wants to merge 1 commit intoChatAndBuild:mainfrom
Conversation
- Added approvedLogic mapping for whitelisting audited logic contracts - setLogicAddress() now requires address to be in allowlist (or address(0)) - Admin functions: approveLogic, revokeLogic, forceResetLogic - Disabled renounceOwnership to prevent locking allowlist - Events for audit trail Deployed & verified on BSC Mainnet: https://bscscan.com/address/0x2b703D4dC84ACB24a0A3F34CBF259D5Cb2B62b19#code Live at: https://synthlaunch.fun/nfa
Contributor
|
Thank you @V-SK, we will review quickly. |
christelbuchanan
requested review from
christelbuchanan,
highsoft-85,
iflp and
snowmanxm
|
@V-SK , there are some failed tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a secure
logicAddressmanagement mechanism through an allowlist pattern, addressing the security concern raised by @ladyxtel regarding governance for upgradeable logic contracts.Changes
Added
contracts/community/NFAv2-SynthLaunch.sol- an enhanced NFA implementation with:1. logicAddress Allowlist ✅
approvedLogicmapping to whitelist audited logic contractssetLogicAddress()now requires address to be approved (oraddress(0))2. Admin Controls
approveLogic(address, reason)- Add to whitelist with audit referencerevokeLogic(address, reason)- Remove from whitelistforceResetLogic(tokenId, reason)- Emergency reset for compromised agentsrenounceOwnership()disabled - Prevents locking the allowlist3. Key Security Features
address(0)always allowed (disable logic)Deployed & Verified
Related Discussion
This addresses the logicAddress governance concern regarding registry/allowlist for upgradeable logic without introducing rug/attack surface.
SynthLaunch - AI Agent Launchpad on BSC