Ability to disable query-target/rsp-subtree/rsp-prop-include in GET r…#102
Open
vmatveyevGit wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Open
Ability to disable query-target/rsp-subtree/rsp-prop-include in GET r…#102vmatveyevGit wants to merge 1 commit intoCiscoTestAutomation:mainfrom
vmatveyevGit wants to merge 1 commit intoCiscoTestAutomation:mainfrom
Conversation
GerriorL
requested changes
Mar 10, 2023
Contributor
GerriorL
left a comment
There was a problem hiding this comment.
Thanks for your submission! Could you please add in a changelog?
Author
Not sure how to add changelog - please see git log output below and let me know what else need to be done. Thanks, [vmatveye@vmatveye-bld2 rest]$ git log commit 2967649 |
Contributor
|
I've made a note of this and will add the changelog on our side. That's a clear enough commit message that it shouldn't be an issue |
GerriorL
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In apic and nxos/aci connectors GET request has query-target/rsp-subtree/rsp-prop-include parameters always added to url.
This does not work for some api requests - for example /mqapi2/deployment.query.json?mode=getvmmCapInfo - that api fails with addition of those parameters.
Changed the code, to give calling function ability to disable those parameters in get, but providing empty values for them, like it is done for other parameters.
Default values for those parameters are non-empty, so it does not change anything for existing scripts.
Also made left stripping "/" in the dn, as that api also fails with "//" in the url - as one "/" is already provided by connect function and another "/" may be present in the dn. This makes apic and nxos connectors consistent with handling dn parameter with and without leading "/".