feat: Use DEFAULT_FROM_EMAIL instead of hardcoding to management command#768
Merged
feat: Use DEFAULT_FROM_EMAIL instead of hardcoding to management command#768
Conversation
* wrapper for django send_mail function that always sets from_email to None * Will make django to use DEFAULT_FROM_EMAIL * test file moved to correct location * CI/CD changes to environment variables and config map needed to have different from_email values env by env Refs: LIIK-906
jforsman
force-pushed
the
email_sender_from_settings
branch
from
e4022bb to
06e9f58
Compare
|
CITYINFRA-API branch is deployed to platta: https://cityinfra-pr768.dev.hel.ninja 🚀🚀🚀 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: LIIK-906