This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Naistenhelsinki#141
Open
ehaivala wants to merge 9 commits intoCity-of-Helsinki:masterfrom
ehaivala:nh
Open
Conversation
Import the prototype app as the starting point for the more finalized version of `naistenhelsinki` app.
The settings and urls need to be configured to get the `naistenhelsinki` prototype app actually working with the project.
Remove unused files from naistenhelsinki app to keep the app clean and concise.
Refactor the model classes of naistenhelsinki app. Create page model for the page that has all the places located on a map. Use OpenStreetMaps for Place map admin widget and set default coordinates to Helsinki instead of the center of Atlantic Ocean (0,0 coordinates). Regenerate all naistenhelsinki migrations because the model renaming.
Fork react-geoview under naistenhelsinki app and configure lightweight webpack and babel for react app compilation.
Remove unused and commented code and unify code style. Split the components to their own files for better structure.
No need to capitalize the directory name. Also use `path.join` in webpack config.
Open detailed place information modal on map place marker click. Implement custom serializer that can serialize python @Property decorated functions as some of those values are needed in the modal.
Do some light layout fixes. Move inline css out of templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create naistenhelsinki app for displaying location data on a map.