Skip to content

ASU-1712: Dont delete after-applications as they are replaced instead #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leevi-identio merged 2 commits into from
Nov 12, 2025
Merged

ASU-1712: Dont delete after-applications as they are replaced instead #802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b76c717
ASU-1712: Dont delete after-applications as they are replaced instead
leevi-identio Nov 12, 2025
847fef3
ASU-1712: Fix lint err
leevi-identio Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion public/modules/custom/asu_application/src/Form/ApplicationForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,8 @@ public function save(array $form, FormStateInterface $form_state) {
/**
* Handle saving the form values.
*
* Deletes old application.
*
* @param array $form
* Form array.
* @param \Drupal\Core\Form\FormStateInterface $form_state
Expand All @@ -548,7 +550,12 @@ private function doSave(array $form, FormStateInterface $form_state, $errors = T
$oldBackendId = $this->entity->get('field_backend_id')->value ?? NULL;
$confirmDeletion = $form_state->getValue('confirm_application_deletion') ?? 'NOT SET';

if ($oldBackendId && $confirmDeletion == '1') {
$project_id = $this->entity->get('project_id')->value;
$project = $this->entityTypeManager->getStorage('node')->load($project_id);
$canApplyAfterwards = $project->get('field_can_apply_afterwards')->value;

// Applications made after shouldn't be deleted.
if ($oldBackendId && $confirmDeletion == '1' && !$canApplyAfterwards) {
try {
$user = \Drupal::entityTypeManager()->getStorage('user')->load(\Drupal::currentUser()->id());
\Drupal::service('asu_api.backendapi')->deleteApplication($user, $oldBackendId);
Expand Down