Skip to content

UHF-X: Change postcss processing so that logical properties are preserved #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teroelonen merged 1 commit into from
Jan 9, 2025
Merged

UHF-X: Change postcss processing so that logical properties are preserved #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/css/ckeditor.min.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/nav_toggle.min.css
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions dist/css/styles.min.css
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion postcss.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,15 @@ module.exports = {
plugins: [
// Plugins for PostCSS
['autoprefixer', { sourceMap: isDev }], // Parses CSS and adds vendor prefixes.
'postcss-preset-env', // Convert modern CSS into something most browsers can understand.
[
'postcss-preset-env', // Convert modern CSS into something most browsers can understand.
{
stage: 2, // Use stage 2 CSS features.
features: {
'logical-properties-and-values': false // Disable the conversion of css logical properties such as padding-inline.
},
},
],
'postcss-nested', // Unwrap nested rules like how Sass does it.
'postcss-nesting', // Nest style rules inside each other, following the CSS Nesting specification.
require('./postcss.plugins'), // Strip inline comments.
Expand Down
15 changes: 2 additions & 13 deletions src/scss/05_objects/_card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,7 @@ $item-gap: $spacing-half;

.card__meta {
@include font('body');
padding-left: $spacing-double; // icon-size + gap

[dir='rtl'] & {
padding-left: 0;
padding-right: $spacing-double; // icon-size + gap
}
padding-inline-start: $spacing-double; // icon-size + gap

& + & {
margin-top: $item-gap;
Expand All @@ -144,13 +139,7 @@ $item-gap: $spacing-half;
.card__meta__icon {
--icon-size: #{$spacing-and-half};
display: inline-block;
margin-left: - $spacing-double;
margin-right: $spacing-half;

[dir='rtl'] & {
margin-left: $spacing-half;
margin-right: - $spacing-double;
}
margin-inline: - $spacing-double $spacing-half;
}

.card__meta__label {
Expand Down
8 changes: 0 additions & 8 deletions src/scss/06_components/pages/_news-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,6 @@
}

[dir='rtl'] & {
padding-left: 0;
padding-right: $spacing + $spacing-quarter;

@include breakpoint($breakpoint-l) {
padding-left: 0;
padding-right: $spacing-and-half + $spacing-quarter;
}

&::before {
left: auto;
right: 0;
Expand Down
4 changes: 4 additions & 0 deletions src/scss/06_components/paragraphs/_hero.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ $koro-height: 50px;
// Hero image author styles.
.hero__image-author {
--arrow-element-width: 100px;

// We can't use the margin-inline-start here because the hero__image-author can have dir-attribute on the
// html-element and this will cause the margin to be on the wrong side since this spacing is here to avoid the
// image author text from going under the arrow in hero element.
margin-left: var(--arrow-element-width);
margin-top: $spacing;
text-align: right;
Expand Down
Loading