Skip to content

Comments

Added accidentally deleted video if-clause back#1173

Merged
annadruid merged 1 commit intomainfrom
UHF-X-missing-video-fix
Feb 4, 2025
Merged

Added accidentally deleted video if-clause back#1173
annadruid merged 1 commit intomainfrom
UHF-X-missing-video-fix

Conversation

@annadruid
Copy link
Contributor

@annadruid annadruid commented Feb 4, 2025

UHF-0000

What was done

  • Added back video if-clause that was accidentally removed and cause video cookie acceptance to break

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • `composer require drupal/hdbt:dev-UHF-X-missing-video-fix
  • Run make drush-cr

How to test

  • Add a video paragraph to for example basic page and make sure that the video is visible when cookies are accepted
  • Check that code follows our standards

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, sorry for this! 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install-drupal-from-scratch Select this to install Drupal from scratch in visual regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants