UHF-11508: Fixing the ploughing timetable search UI#1218
Merged
Conversation
…initial value is an empty string instead of undefined.
|
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1218/html_report/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UHF-11508
Ploughing timetable search in https://www.hel.fi/fi/kaupunkiymparisto-ja-liikenne/kunnossapito/katujen-kunnossapito/katujen-talvikunnossapito#milloin-autotiet-aurataan- has an issue where the input field can not be fully emptied after something's been written.
What was done
The issue was caused by a
downshift-error due toaddressstate property getting an initial value ofundefined. Added a fix to make sure the initial value is an empty string instead.How to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-11508_ploughingmake drush-crHow to test
street_data-index, but it doesn't matter if you don't)Continuous documentation