UHF-11535: Read matomo site id from drupalSettings#1223
Merged
jeremysteerio merged 3 commits intomainfrom Mar 20, 2025
Merged
Conversation
|
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1223/html_report/ |
2 tasks
|
|
teroelonen
approved these changes
Mar 20, 2025
Contributor
teroelonen
left a comment
teroelonen
left a comment
There was a problem hiding this comment.
This should be good 🦖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UHF-11535
What was done
matomo_site_idis present indrupalSettingsHow to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-11535make drush-crHow to test
☝️ These instructions only work if you've set up
helfi_matomomodule and havematomo_site_idpresent indrupalSettingsRun
nvm use; npm iinhdbtdirectoryDo these changes to
matomo.js:window.loadMatomoAnalytics = loadMatomoAnalytics;as the last line of the self-calling function (so we can call this manuallymake drush-cr<head>in the HTML documentloadMatomoAnalytics()in the browser console. This should not produce any errors<head>element again. The first element shold be a<script>tag withsrc="//webanalytics.digiaiiris.com/js/piwik.min.js"Check that this feature works
Check that code follows our standards
Continuous documentation
Translations
Other PRs