UHF-11460: Fix timeout messaging in events app#1230
Merged
jeremysteerio merged 4 commits intomainfrom Apr 1, 2025
Merged
Conversation
|
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1230/html_report/ |
|
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1230/html_report/ |
teroelonen
approved these changes
Mar 27, 2025
Contributor
teroelonen
left a comment
There was a problem hiding this comment.
This works very nicely! I made a small adjustment on the loading spinner since it has been bothering me for so long 🦖
|
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1230/html_report/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UHF-11460
Fix timeout problems in event search
What was done
retriesExhaustedstateHow to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-11460make drush-crHow to test
Need to do some code changes to test this:
cd public/themes/contrib/hdbtnvm use; npm i; npm run devsrc/containers/SearchContainerchange the 3rd argument ofuseTimeoutFetchfrom10 000to1000.Then test out the app:
1000to even lower until the requests failContinuous documentation
Translations
Other PRs