Skip to content

UHF-9700: Small accessibility improvements to language toast#1231

Merged
teroelonen merged 3 commits intomainfrom
UHF-9700
Mar 31, 2025
Merged

UHF-9700: Small accessibility improvements to language toast#1231
teroelonen merged 3 commits intomainfrom
UHF-9700

Conversation

@teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Mar 28, 2025

UHF-9700

What was done

  • Convert the language toast to section and add it aria-label.
  • Add lang-attribute to places where it is needed.
  • Change the close button to same language as to toast as per accessibility expert recommendation.
  • Small styling adjustments based on designer recommendations

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9700
  • Run make drush-cr

How to test

  • Make sure that there is now section tag around the language toast.
  • Make sure that the screen reader pronounces the labels correctly when using the toast.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated.
  • This change doesn't require updates to the documentation.

@github-actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1231/html_report/

@github-actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1231/html_report/

Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@teroelonen teroelonen merged commit 7b0f1b3 into main Mar 31, 2025
2 checks passed
@teroelonen teroelonen deleted the UHF-9700 branch March 31, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants