Skip to content

Added check if title exists#1232

Merged
annadruid merged 1 commit intomainfrom
UHF-X-unit-search-title-fix
Mar 31, 2025
Merged

Added check if title exists#1232
annadruid merged 1 commit intomainfrom
UHF-X-unit-search-title-fix

Conversation

@annadruid
Copy link
Contributor

UHF-0000

What was done

  • Added check if title exists in content-list-with-count template

How to install

  • Make sure your for example SOTE instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-0000_insert_correct_branch
  • Run make drush-cr

How to test

  • Go to hhttps://helfi-sote.docker.so/fi/sosiaali-ja-terveyspalvelut/terveydenhoito/hammashoito/hammashoitolat#etsi-hammashoitoloita and make sure there isn't an empty h2 tag before the input field
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@github-actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1232/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

@annadruid annadruid merged commit fc1f908 into main Mar 31, 2025
2 checks passed
@annadruid annadruid deleted the UHF-X-unit-search-title-fix branch March 31, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants