Skip to content

UHF-11632: Changed banner paddings and margins#1233

Merged
annadruid merged 1 commit intomainfrom
UHF-11632
Mar 31, 2025
Merged

UHF-11632: Changed banner paddings and margins#1233
annadruid merged 1 commit intomainfrom
UHF-11632

Conversation

@annadruid
Copy link
Contributor

@annadruid annadruid commented Mar 31, 2025

UHF-11632

What was done

  • Changed banner paddings and margins to match design

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11632
  • Run make drush-cr

How to test

  • Create a banner on for example a basic page
  • Make sure the surrounding paddings and now 24px below 992px and 32px above it
  • Make sure banner content has always 16px margin top
  • Make sure the link button has 24px of margin below 992px and 32px above it
  • Check that code follows our standards

@github-actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1233/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go 🦖

@annadruid annadruid merged commit 0030436 into main Mar 31, 2025
2 checks passed
@annadruid annadruid deleted the UHF-11632 branch March 31, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants