Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a noConsole rule to the Biome linter configuration to restrict the use of console.log in JavaScript files, while still allowing other console methods like assert, error, info, and warn. This brings the Biome configuration in line with the previous ESLint ruleset.
Key Changes:
- Added
noConsolerule with warning level to thesuspiciousrules section - Configured allowed console methods (
assert,error,info,warn) while blockingconsole.log - Reformatted the
suspiciousrules object for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theme-builder/biome.json
Outdated
| ] | ||
| } | ||
| }, | ||
| "noGlobalIsFinite":"off" |
There was a problem hiding this comment.
Missing space after colon in "noGlobalIsFinite":"off". For consistency with the rest of the file's formatting style (e.g., line 15), this should be "noGlobalIsFinite": "off" with a space after the colon.
| "noGlobalIsFinite":"off" | |
| "noGlobalIsFinite": "off" |
|
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1453/html_report/ |
UHF-0000
What was done
How to install
git checkout dev && git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-X-add-no-console-rulemake drush-locale-update drush-crHow to test
console.logto any js file that gets linted. This should trigger an error when runningnpm run lint:jsornpm run build