Skip to content

Comments

UHF-12420: TOC loading text#1454

Merged
teroelonen merged 1 commit intomainfrom
UHF-12420_toc_loading_screen
Dec 8, 2025
Merged

UHF-12420: TOC loading text#1454
teroelonen merged 1 commit intomainfrom
UHF-12420_toc_loading_screen

Conversation

@teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 8, 2025

UHF-12420

What was done

  • Show loading screen when the TOC is loading.

How to install

  • TEST THIS WITH ETUSIVU. Make sure your instance is up and running on latest dev-branch
    • git checkout dev && git pull origin dev
    • make fresh
  • Switch to feature branch
    • git fetch && git checkout UHF-12420_toc_loading_screen*
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-12420_toc_loading_screen
  • Run code updates
    • make drush-locale-update drush-cr

How to test

  •  Check that the loading screen is now visible when the TOC is loading. Any place is good to check this, but Helsinki lähelläsi is one good place.
  • Check that the updating news TOC also looks good and that the loading screen doesn't have a ball in front of the text.
  • Check that the code follows our standards.
  • Check that the differences in visual regression tests are appropriate.

Links to related PRs

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1454/html_report/

@teroelonen teroelonen changed the title UHF-12420: Remove styles that hide the loading screen from being visible on TOC UHF-12420: TOC loading text Dec 8, 2025
@teroelonen teroelonen merged commit 885611a into main Dec 8, 2025
6 checks passed
@teroelonen teroelonen deleted the UHF-12420_toc_loading_screen branch December 8, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants