Skip to content

Comments

UHF-12607: Fix GhostCard and url-parameter type error issues on job search#1456

Merged
teroelonen merged 4 commits intomainfrom
UHF-12607
Dec 11, 2025
Merged

UHF-12607: Fix GhostCard and url-parameter type error issues on job search#1456
teroelonen merged 4 commits intomainfrom
UHF-12607

Conversation

@teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 10, 2025

UHF-12607

What was done

  • Changed the GhostCards to be displayed in a similar way as in School search.
  • Fix issues with url parameters being interpret incorrectly for example when refreshing the job search page with some filters applied.
  • Don't show the pager when there is results for only one page.

How to install

  • Make sure your instance is up and running on latest dev-branch
    • git checkout dev && git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-12607
  • Run code updates
    • make drush-locale-update drush-cr

How to test

  •  Go to https://helfi-rekry.docker.so/fi/avoimet-tyopaikat and add some filters for the front page block. Submit and make sure the results are shown correctly.
  • Add some network throttling and change the filters on the search. Make sure that multiple ghost cards are shown and that the previous results don't linger but are replaced with the ghost cards instead while loading. You can check what the broken layout looked like from the ticket.
  • Now you need to test the filters carefully: Change all the filters, submit the search AND then refresh the page after seeing the results. The refresh should show the same results and console shouldn't have any errors. Test all kinds of combinations.
  • For the final check, select filters that yields less than 15 results. Make sure the pager is not visible. No point in showing the pager in the case where it cannot be used.
  • Check that the code follows our standards.
  • Check that the differences in visual regression tests are appropriate.

…ool search to fix issues when filtering the results, fix issues with url parameters being interpret incorrectly when refreshing the job search page with some filters applied
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1456/html_report/

@teroelonen teroelonen merged commit 7737bb0 into main Dec 11, 2025
6 checks passed
@teroelonen teroelonen deleted the UHF-12607 branch December 11, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants