UHF-12501: Biome ignore refactoring#1468
Merged
teroelonen merged 29 commits intomainfrom Jan 13, 2026
Merged
Conversation
…le, refactor some max-nesting-depth and number-max-precision issues
…ch and in the common template ResultsEmpty
…OnlyClass and noAssignInExpression ignores could be removed
…ssFragments ignore could be removed
|
|
Contributor
There was a problem hiding this comment.
Using Math.random for key props is antipattern. You could probably just use the _id value of Result for unique id.
|
|
||
| return ( | ||
| // biome-ignore lint/a11y/useSemanticElements: @todo UHF-12501 | ||
| // biome-ignore lint/a11y/useSemanticElements: The semantic element <search> doesn't exist in 'JSX.IntrinsicElements' so we can't use it at this point. If updates allow it later, remove the role and wrap the form in a <search> element. |
Contributor
There was a problem hiding this comment.
This is a typescript issue, so we can use <search> elements. Our typings are lagging behind since our react version is locked. If we want to wrap all search forms in search, we should do so and use // @ts-ignore instead
Contributor
Author
There was a problem hiding this comment.
This is good idea, commented and lets do this on the next ticket!
jeremysteerio
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UHF-12501
What was done
How to install
git checkout dev && git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-12501make drush-locale-update drush-crHow to test