Skip to content

Comments

UHF-12470: Add keyword tag to search monitor selections list#1473

Merged
jeremysteerio merged 10 commits intomainfrom
UHF-12470
Jan 19, 2026
Merged

UHF-12470: Add keyword tag to search monitor selections list#1473
jeremysteerio merged 10 commits intomainfrom
UHF-12470

Conversation

@jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Jan 15, 2026

UHF-12470

What was done

  • Fix issues from AC testing

How to install

  • Make sure your instance is up and running on latest dev-branch
    • git checkout dev && git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-12470
  • Run code updates
    • make drush-locale-update drush-cr

How to test

Links to related PRs

Copilot AI review requested due to automatic review settings January 15, 2026 11:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a keyword tag to the search monitor selections list and includes a link to more detailed instructions for using saved searches. The changes fix issues identified during acceptance criteria (AC) testing.

Changes:

  • Added keyword selections to the search monitor dialog with proper formatting (wrapped in quotes)
  • Added optional instructions link in the search monitor dialog
  • Extended Drupal settings to expose the instructions link URL

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/js/react/apps/job-search/containers/SearchMonitorContainer.tsx Added keyword filtering to visible selections and conditional rendering of instructions link
src/js/types/drupalSettings.d.ts Added TypeScript type definition for new instructions link URL setting
hdbt.theme Extended configuration loading to include the new instructions link URL setting
translations/fi.po Added Finnish translation for instructions link text
translations/sv.po Added Swedish translation for instructions link text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1473/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved from my side 🦖

@jeremysteerio jeremysteerio merged commit 2d8587e into main Jan 19, 2026
6 checks passed
@jeremysteerio jeremysteerio deleted the UHF-12470 branch January 19, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants