Skip to content

Comments

UHF-12543: Changed askem margin top#1488

Merged
annadruid merged 1 commit intomainfrom
UHF-12543
Jan 30, 2026
Merged

UHF-12543: Changed askem margin top#1488
annadruid merged 1 commit intomainfrom
UHF-12543

Conversation

@annadruid
Copy link
Contributor

@annadruid annadruid commented Jan 30, 2026

UHF-12543

What was done

  • Changed askem margin top so be same as in design

How to install

  • Make sure your instance is up and running on latest dev-branch
    • git checkout dev && git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-12543
  • Run code updates
    • make drush-locale-update drush-cr

How to test

  •  See kasko PR
  • Check that the code follows our standards
  • Check that the differences in visual regression tests are appropriate

Links to related PRs

Copilot AI review requested due to automatic review settings January 30, 2026 06:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the top margin of the Askem block component to align with design specifications. The change replaces the mixin-based margin with explicit responsive spacing values.

Changes:

  • Modified Askem block component margin-top to use explicit spacing tokens instead of a mixin
  • Added responsive margin-top behavior with different values for mobile and desktop breakpoints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1488/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice 🦖

@annadruid annadruid merged commit 2f6bfda into main Jan 30, 2026
7 checks passed
@annadruid annadruid deleted the UHF-12543 branch January 30, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants