UHF-12620: Fix generating course url#1498
Merged
jeremysteerio merged 3 commits intomainfrom Feb 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the generation of course URLs in the cross-institutional studies search functionality by updating the URL construction logic to use language-specific base URLs.
Changes:
- Added
baseUrlsobject to TypeScript type definitions with language-specific URL entries - Updated URL generation logic to use the new language-specific base URLs instead of concatenating language to a single base URL
- Updated compiled JavaScript to reflect the source code changes
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/js/types/drupalSettings.d.ts | Added baseUrls property with language-keyed URL mapping to support language-specific base URLs |
| src/js/react/apps/linkedevents/modules/cross-institution-studies/components/ResultCard.tsx | Updated getUrl function to use language-specific base URLs from the new baseUrls object |
| dist/js/linkedevents.min.js | Updated minified JavaScript bundle with the new URL generation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1498/html_report/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UHF-12620
What was done