UHF-12819 fix highschool search

[rpnykanen]

UHF-12819

Fixed the high school search
Fixed the disable field-feature

What was done

• Fixed the high school search query by adding IN-operator
• Added new noclick-class to hdbt
• Tampering ajax-views´ filters with custom JS causes problems
  • Fixed by using css to disable the field
  • Also, when the field is disabled, the value must be is reseted to ´All´. Without this step, the backend would include the selected value to the query even when the field is disabled.

How to install

• Make sure your instance is up and running latest version of dev-branch
  • git checkout dev && git pull origin dev
  • make fresh
• Switch to feature branch
  • git fetch && git checkout UHF-12819
• Update the HDBT theme
  • composer require drupal/hdbt:dev-UHF-12819
• Run code updates
  • composer install
  • make drush-deploy drush-locale-update drush-cr

How to test

Broken search

• Go to high school search page (hard refresh browser maybe)
• Select filters - press Search

You should get results, no backend ajax errors
(Note: The disabled field still works with keyboard controls but the feature still works in consistent manner)

Broken disable field -feature

• Have one of the two top filters (emphasis) selected - press Search
• Now revert the selection and select the second top filter - press Search
  • This used to give 0 results since backend would use both emphasis field values in the query
• Check that the aria-disabled is set properly on the emphasis fields

The second search should give results
Aria-disabled is set properly

Links to related PRs

HDBT-PR

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud