Conversation
hyrsky
force-pushed
the
UHF-9754
branch
2 times, most recently
from
758a76e to
fed9553
Compare
I chickened out on the decision to delete field_api_url because if something goes wrong with the update hooks, it makes it much harder to reconstruct the previous settings. The field is no longer used and should be deleted once the new functionality is validated.
|
jeremysteerio
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UHF-9754
I chickened out on the decision to delete field_api_url because if something goes wrong with the update hooks, it makes it much harder to reconstruct the previous settings.
The field is no longer used and should be deleted once the new functionality is validated. Everything in the field_api_url should be migrated to the new fields added in #978.
How to install
git checkout 2025-06-04.1.make fresh.git checkout devcomposer require drupal/helfi_platform_config:dev-UHF-9754 -W; composer installHow to test:
drush updbdrush helfi:platform-config:updatedrush sqlq "select * from paragraph__field_api_url;".