Skip to content

Comments

Make sure commit-msg Git hook is executable#303

Merged
tuutti merged 1 commit intomainfrom
UHF-X-commit-msg-executable
Jan 22, 2025
Merged

Make sure commit-msg Git hook is executable#303
tuutti merged 1 commit intomainfrom
UHF-X-commit-msg-executable

Conversation

@tuutti
Copy link
Contributor

@tuutti tuutti commented Jan 22, 2025

What was done

Git complains about non-executable hooks and it's never run:

hint: The '.git/hooks/commit-msg' hook was ignored because it's not set as executable.
hint: You can disable this warning with git config advice.ignoredHook false.

How to install

  • Copy the changed tools/make/git.mk file to your project

How to test

  • Make sure .git/hooks/commit-msg is not executable (in project root or in module/theme folders)
  • Run make copy-commit-message-script and make sure the script is now executable

@sonarqubecloud
Copy link

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! 🚀

@tuutti tuutti merged commit 2752284 into main Jan 22, 2025
3 checks passed
@tuutti tuutti deleted the UHF-X-commit-msg-executable branch January 22, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants