Draft
Conversation
Convert municipality codes from integers to 3-character strings with leading zeros to ensure proper representation and consistency across the codebase. Changes: - Update MUNICIPALITIES constant to use 3-char string codes (e.g., 91 → "091") - Modify municipality and address import services to convert codes using str(int(code)).zfill(3) - Update all factories and tests to use 3-character string codes consistently Refs: RATYK-163
- Add municipality filter parameters to MunicipalityViewSet with OpenAPI documentation - Add comprehensive tests for municipality filtering by name and code Refs: RATYK-163
BREAKING CHANGE: Detail endpoints removed for address, municipality and postal code area resources. Clients must use list endpoints with filters instead of retrieving resources by ID. Remove retrieve/detail endpoints from AddressViewSet, MunicipalityViewSet and PostalCodeAreaViewSet, leaving only the list endpoint available for each resource. Update postal code area translation test to use list endpoint with postalcode filter instead of detail endpoint. Refs: RATYK-158
|
|
PAIKKATIETOHAKU-API branch is deployed to platta: https://paikkatietohaku-api-pr100.api.dev.hel.ninja 🚀🚀🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates:
BREAKING CHANGE: Detail endpoints removed for address, municipality and postal code area resources. Clients must use list endpoints with filters instead of retrieving resources by ID.Refs: RATYK-158, RATYK-163