Skip to content

Comments

Add support for ruff, pre-commit, commitlint, pyproject.toml and dependabot#73

Merged
mhieta merged 16 commits intomainfrom
ruff
Mar 18, 2025
Merged

Add support for ruff, pre-commit, commitlint, pyproject.toml and dependabot#73
mhieta merged 16 commits intomainfrom
ruff

Conversation

@mhieta
Copy link
Contributor

@mhieta mhieta commented Mar 11, 2025

Updates:

  • Use ruff instead of Black, Flake8 and isort
  • Use commitlint
  • Use pyproject.toml instead of setup.cfg
  • Update requirements
  • Add pre-commit to project
  • Update project readme
  • Use common CI setup
  • Add dependabot CI-config
  • Update release-please configuration

Refs: RATYK-92, RATYK-93

@mhieta mhieta requested a review from a team March 11, 2025 11:58
@terovirtanen
Copy link
Contributor

PAIKKATIETOHAKU-API branch is deployed to platta: https://paikkatietohaku-api-pr73.api.dev.hel.ninja 🚀🚀🚀

Copy link
Contributor

@danipran danipran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some discrepancy with Postgres/Python versions within the project. Make sure they're consistent across the board.

Also noticed that 8e5418b (ci: migrate to pyproject.toml) contains commitlint changes as well. Split this to its own commit.

@terovirtanen
Copy link
Contributor

PAIKKATIETOHAKU-API branch is deployed to platta: https://paikkatietohaku-api-pr73.api.dev.hel.ninja 🚀🚀🚀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 17, 2025

@terovirtanen
Copy link
Contributor

PAIKKATIETOHAKU-API branch is deployed to platta: https://paikkatietohaku-api-pr73.api.dev.hel.ninja 🚀🚀🚀

@mhieta mhieta requested a review from danipran March 17, 2025 14:05
@mhieta
Copy link
Contributor Author

mhieta commented Mar 17, 2025

There's some discrepancy with Postgres/Python versions within the project. Make sure they're consistent across the board.

Updated to use PostgreSQL 14 and Python 3.12 across the project.

Also noticed that 8e5418b (ci: migrate to pyproject.toml) contains commitlint changes as well. Split this to its own commit.

Splitted commitlint into own commit.

Copy link
Contributor

@danipran danipran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mhieta mhieta merged commit 2710f62 into main Mar 18, 2025
21 checks passed
@mhieta mhieta deleted the ruff branch March 18, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants