Skip to content

Comments

chore: rewrite CI workflows to build once and add logic#1511

Merged
mrTuomoK merged 1 commit intodevelopmentfrom
HDS-2332-shared-builds-for-workflows
Apr 30, 2025
Merged

chore: rewrite CI workflows to build once and add logic#1511
mrTuomoK merged 1 commit intodevelopmentfrom
HDS-2332-shared-builds-for-workflows

Conversation

@mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Apr 29, 2025

Refs: HDS-2332

Description

Rewrote the CI-workflow's to build packages only once and use them in the latter flows. Also deploys the site demos a bit differenty now.

Single version demo-site when: PR to development or running workflow-dispatch
Multi when: PR targetting master, push to development or master or release-*

Had to add new env and script to site's package.json BUILD_SINGLE_VERSION since gatsby build forces the previously used development env to false which could not be used anymore.

Also cleans up the artifacts right after successful builds.

Example flow:
CleanShot 2025-04-29 at 08 45 39@2x

and after PR to development:
CleanShot 2025-04-29 at 09 09 40@2x

Related Issue

Closes HDS-2332

Motivation and Context

Greener code, faster in some cases too.

How Has This Been Tested?

  • running the flows a lot (OK the releases haven't been able to test yet)

Demos:

Links to demos are in the comments

Add to changelog

  • not needed

@mrTuomoK mrTuomoK requested a review from timwessman April 29, 2025 05:41
@github-actions
Copy link

Test Results

  1 files   68 suites   17m 37s ⏱️
 88 tests  88 ✅ 0 💤 0 ❌
176 runs  176 ✅ 0 💤 0 ❌

Results for commit 3944e20.

@github-actions
Copy link

Preview found from hds-demo docs/preview_1511

Demos

Docs
Core Storybook
React Storybook

Copy link
Contributor

@timwessman timwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@mrTuomoK mrTuomoK merged commit 2d421b6 into development Apr 30, 2025
12 checks passed
@mrTuomoK mrTuomoK deleted the HDS-2332-shared-builds-for-workflows branch April 30, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants