Merged
Conversation
Contributor
eemeli-kukkonen-siili
commented
Dec 4, 2025
eemeli-kukkonen-siili
commented
- KAAV-1511 Aikataulun muokkauks raahaus V1
- KAAV-3260 Tallennuksen indikaatio, virheilmoitus kentän yhteyteen
* KAAV-1511 Timeline values to be draggable, draggable values to visiually move in timeline, draggable values to move other time values, update data and trigger validations. * KAAV-1511 dragging different styles for interactions. Date to show as tooltip when dragging. Prevent dragging when phase is closed or confirmed or date is in the past. * KAAV-2054 Muokkausnäkymän infolaatikosta siirryttäessä sivupaneelin tulee olla avoinna (1.1.2) (#510) * KAAV-2054 infobox to open matching timetable sidepanel from link * KAAV-2054 sonarcloud improvements * KAAV-2472 Element delete button to be disabled if it is confirmed (#518) * KAAV-2416 Työkalurivin marginaalit ja sijainti ei vastaa leiskaa (1.1.2) (#520) * KAAV-2416 timeline toolbar position style fixes * KAAV-2416 vis timeline height to stretch all the way bottom and show overflow when items overflow height * KAAV-2421 year/month calendar style changes * KAAV-2420 timetable zoom row style fixes (#521) * KAAV-2731 When saving a certain field at projectEdit form show loading spinner in field or close to it as long as saving is in progress. (#533) * KAAV-2724 help links to dokument location images implement to help tooltips (#535) * KAAV-2623 timetable collapse buttons not to open when clicking select options from timetable calendar modals (#545) * KAAV-2618 Käynnistysvaiheen "Vaiheen lisätiedot"-kohta ei näy valittuna, vaikka se on auki (1.1.2) (#546) * KAAV-2623 timetable collapse buttons not to open when clicking select options from timetable calendar modals * KAAV-2618 additional checks for highlighting timetable selected phases * KAAV-3098 When opening timetable edit, show year view as selected (#554) * KAAV-2437 fix unnecessary black borders (#556) Co-authored-by: henrihaapalasiili <henri.haapala@siili.com> * KAAV-2441 Secondary painikkeiden tilat (hover, focus, yms) ei vastaa HDS:ää (1.1.2) (#557) * KAAV-2437 fix unnecessary black borders * KAAV-2441 add fixes for secondary button styles --------- Co-authored-by: henrihaapalasiili <henri.haapala@siili.com> * KAAV-2435 Rivin lisääminen - menu ei vastaa leiskaa (1.1.2) (#558) * KAAV-2437 fix unnecessary black borders * KAAV-2441 add fixes for secondary button styles * KAAV-2435 fix add line menu to match the design * KAAV-2435 add gap between button and menu --------- Co-authored-by: henrihaapalasiili <henri.haapala@siili.com> * KAAV-2422 add style fixes to gant component (#560) Co-authored-by: henrihaapalasiili <henri.haapala@siili.com> * KAAV-2310 highlights to elements at timeline when selecting one for edit (#561) * KAAV-2418 fix fonts in calendar area (#562) Co-authored-by: henrihaapalasiili <henri.haapala@siili.com> * KAAV-2422 add style fixes for gantt component * KAAV-2422 add more stye fixes * KAAV-2251 add changes to the behavior of opening, closing, and switching content on the side panel * KAAV-2251 refactor code to reduce cognitive complexity * KAAV-2776 remove usage of DocumentConfirmationModal * KAAV-2776 remove unnecessary fragment from Document component * KAAV-2937 spinner fixes * KAAV-2054 linked deadline from form to redirect to timeline and when opening the right modal also highligh the phase * KAAV-2472 confirmation to change false if phase is deleted from timeline * KAAV-2417 center buttons vertically * KAAV-2620 disable dropdown while page is loading so that the button can't be clicked too early * KAAV-2620 add PropTypes * KAAV-1304 fix centering of download document -links * KAAV-2310,2618 added classes to vis timeline menu elements to help highlight, save higlights to localstorage and remove them when browser refresh or confirm/cancel timeline edit * KAAV-2310 remove small timeout so the highlighting will not flicker when selecting dates from sidebar * KAAV-2422 add fix for gantt area height issues * KAAV-2074 Alasvetovalikoista ei tule esiin tietoja ensimmäisellä klikkauksella (1.1.3) (#571) * KAAV-2074 get all personnel so when clicking combobox users are shown * KAAV-2074 lazy loading personnel results while scrolling all personnel * KAAV-2074 multiselect(project list search) and single select(main form user select) lazy load and fetch to work and styles/behavior to mimic HDS component * quality fixes * KAAV-2422 add style fix for timetable modification action buttons * 1.1.2 add updated yarn.lock with correct packages * KAAV-2422 add minor style fixes for gantt area * KAAV-1511 enable dragging from vis options * KAAV-2657 SonarCloud kriittisimmät ongelmat (FE) (#579) * KAAV-2657 refactor checkConfirmedGroups function to reduce it's cognitive complexity * KAAV-2657 remove commented code * KAAV-2657 reduce cognitive complexity of checkConfirmedGroups * KAAV-2657 refactor useEffect to reduce cognitive complexity * KAAV-2657 refactor addDeadLineGroups to reduce cognitive complexity * KAAV-2657 simplify getExpandedState and add props validation * KAAV-2657 remove unnecessary return statement from handleInputChange * KAAV-2657 refactor findMatchedDeadline from CustomCard to reduce it's cognitive complexity * KAAV-2657 refactor buildDeadlineAttribute to not use nested template literals * KAAV-2657 refactor normalOrRollingElement from SelectInput to reduce cognitive complexity * KAAV-2657 remove commented out code * KAAV-2660 Frontin konsolivirheiden jäljitys (FE) (#582) * KAAV-2660 remove each child in a list should have a unique key -error from the project list * KAAV-2660 add tbody to table to remove error from the console * KAAV-2660 remove invalid prop value error from console * KAAV-2660 remove warning about unique key prop pointing to FormSection * KAAV-2660 destructure props to avoid spreading custom props to DOM * KAAV-2660 fix PropTypes validation for deadlines at CustomCard * KAAV-2660 fix SonarCloud issue * KAAV-2983 timetable save and cancel buttons to have loading cursors and HDS style like success toastr (#585) * KAAV-3193 Dependabot and codescanning improvements (#586) * KAAV-3193 enforce memory limits to deployment.yaml based on prod metrics * KAAV-3193 update path-to-regexp, update css syntaxes that are out of date * KAAV-3228 Vite to replace react-scripts,craco and old version of webpack-dev-server that they had dependancys and were unable to update it anymore * KAAV-3193 SonarCloud fixes * KAAV-3193 Sonarcloud reliability fixes * KAAV-2700 - Fieldsetin itemin lisäyksen/poiston parannukset (#587) * Vite css compiler related modifications * KAAV-2700 removed console log * KAAV-2700 fieldset remove button spinner improvements * KAAV-2700 (#588) * Vite css compiler related modifications * KAAV-2700 removed console log * KAAV-2700 fieldset remove button spinner improvements * fixes import syntax on hds-core * KAAV-1772 Modify redux toastr to look like HDS toastr (#589) * Removed non used variables and states * Use callback in setState when referencing the previous state * yarn lock update * fixed typo on import * more case-insensitive file name fixes * naming fixes * Vite scss problem fix * Vite to use build folder and not dist * KAAV-3250 Keep original value if richtext is emptied and focus is removed, set error aftet blur false (#594) * KAAV-1511 merged 1.1.4 * Node update for Vite * package.json update on node versions * Node to 22 version so redhat downloads compatible version for all Vite features(if used in future) * KAAV-3250 it needs to be possible to empty required richtext * KAAV-3250 example text possible to be emptied and errors to show correctly * KAAV-3262 fieldset spinner is showing when it should not * KAAV-3261 Fieldset buttons and spinners modifications * Link spinner and error control, spinner colors fix * KAAV-2657 Software qualities blocker fix * fixed buttons not showing at edit view menu * KAAV-2700 fieldset loading spinner fixes * KAAV-1772 error toastr text color, opacity and box shadow fix * Vite configs to force clear cache * testing build cache clean * fix delete button showing when deleting in progress * hide delete button when deleting * 1.1.4 delete border color important * KAAV-2700 Adding not activating spinner on fieldset if fieldset was not opened before fix * KAAV-2700 Fieldset spinners to show when supposed to * KAAV-2700 Fieldset spinners to show when supposed to * KAAV-2700 saving animation shows up on last edited fieldst when editing richtext fix * yarn lock update * KAAV-1511 Allow element dragging only from places where it is designed and prevent multi date moving. Prevent roles that have no edit right to timeline dates to try and drag dates * KAAV-1511 add some constraint to dragging before validation so user cannot try to drag element earlier then previous phase for example * fixed sonarCloud issue * KAAV-1511 fixed check mark moves on hover at some cases, added phase some elements cannot be moved right away fixed * gitignore add * KAAV-1511 board date cannot be dragged to any direction fix * KAAV-1511 fixed phase line not moving to actual phase last date when dragging date to holiday and when it is automatically adjusted to non holiday * KAAV-1511 periaatteet phase at timeline to be open when the phase is ongoing fix * KAAV-1511 fixed later phases phase lines can appear earlier then earlier phase in timeline fix * KAAV-1511 drag icons to appear correctly * KAAV-1511 improved styles * KAAV-1511 prevent dragging voimaantulo and hyvaksyminen phases * KAAV-1511 bug fixes * KAAV-1511 box-shadow when dragging only to draggable element group * KAAV-1511 disabled elements not to show drag cursors * KAAV-1511 prevent seeing drag cursors etc if no right to edit * KAAV-1511 style fixes * KAAV-1511 added moving point for element group between start and end date that is determined in designs that moves elements similarely then maaraika dragging * KAAV-1511 style changes * KAAV-1511 drag all items inside group if they should move in consequence of item dragged * Fixed hyvaksyminen and voimaantulo showed some dragging symbols when tried to drag, nahtavillaolo center dragging did not work fix * KAAV-1511 enable kaynnistys phase center dragging, styles for kaynnistys phase center dragging, prevent moving confirmed phases with dragging * KAAV-1511 adding new sub phases should increase main phase length fix * KAAV-1511 Keep timespan between start and end and not reset it to default when moving maaraiaika or start date or dranggin in any way * Sonarcloud improvement * KAAV-1511 lautakunta confirm style fix and lautakunta confirm to appear on added lautakunta dates too * KAAV-1511 when deleting phase item the element phase should shrink * KAAV-1511 range stays for elements when dragging, removed dragging points from individual points for v1 and left only whole element dragging points, style changes. * KAAV-1511 style changes for v1 * KAAV-1511 XS-M nahtavilla olo style fixes * KAAV-1511 Separate styles for XL,L nahtavillaolo when dragging * KAAV-1511 element structure breaks visually if dragged to past fix * KAAV-1511 prevent element dragging to past * KAAV-1511 added missing action * KAAV-1511 prevent timeline elements range line from breaking visually apart from the movable element, when user rapidly moves elements and prevent it from seeming like you can move the range line * KAAV-1511 removed misleading confirm context text * KAAV-1511 disabled saving when validating timetable elements * KAAV-1511 prevent dragging later group before previous group * KAAV-1511merged kaynnistys_1 scss was overwritten fix --------- Co-authored-by: Minna Honkanen <159889008+MinnaSiili@users.noreply.github.com> Co-authored-by: Minna Honkanen <minna.honkanen@siili.com>
* KAAV-2247 Käyttäjälle kerrotaan (tooltip), miksi toimintopainike-painike on passiivinen (#597) * KAAV-2247 add grey plus icon for disabled add button * KAAV-2247 add custom react hook for timeline tooltips * KAAV-2247 update translations * KAAV-2247 add style updates related tooltip changes * KAAV-2247 update add-buttons logic * KAAV-2247 add phase status related logic * KAAV-2247 add locig for the confirm dates button * KAAV-2247 add tooltips for right side panel * KAAV-2247 add more translations * KAAV-2247 add confirm dates button tooltips for esillaolo/nahtavillaolo also * KAAV-2247 update component to show tooltips for disabled buttons * KAAV-2247 Refactored renderSection to smaller helper functions --------- Co-authored-by: henrihaapalasiili <henri.haapala@siili.com> * KAAV-2207 Elementtirivien toimintalogiikan lisävaatimukset (muut paitsi dialogi) (#607) * KAAV-2207 additional rules to element row confirmations and adding and deleting * KAAV-2207 removed console logs * KAAV-2207 timeline confirmation fields for ongoing phase need to be checked before phase can be closed, if all other required fields from form have filled * KAAV-2864 Loading documents requires current phases timetable to have atleast 1 sub phase confirmed, exception in phases where there are no confirmations in timetable * KAAV-2590 Aikataulun muokkauksen pakollisten kenttien tarkistus lopeta vaihe -painikkeella (#613) * KAAV-2590 check acceptance phase required fields when end phase button is pushed and show them at required fields error, new styles for required fields notification * KAAV-2590 timetable error link redirects to timetable and opens correct phase. Only end phase button shows timetable errors. * KAAV-3228 Vite duplicate style generation fix (#614) * KAAV-2309 add symbols for timeline menu tooltip * KAAV-2309 add timeline menu tooltip * KAAV-2309 add changes related timeline tooltips * KAAV-2309 fix Firefox related style issue * KAAV-2309 add style changes related to timeline tooltips * KAAV-3120 Timeline zoom 2 years, 3 months and 6 months (#616) * Bump axios from 1.11.0 to 1.12.0 (#610) Bumps [axios](https://github.com/axios/axios) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.12.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * KAAV-2309 refactor to reduce cognitive complexity * KAAV-2309 add styling fix * KAAV-2309 fix tooltip position * KAAV-2980 add underline to current day in month view, fix background position * KAAV-2207 use actual esilläolo/nähtävilläolo start date for disabling confirmation when dates are in the past * KAAV-2590 fix error in phase closing logic * KAAV-2247 Show custom tooltip for both confirm and un-confirm * KAAV-2247 Add comprehensive tooltip logic for all confirm/un-confirm button states in TimelineModal * KAAV-2247 Increase bottom padding in timeline modal to make room for tooltip * Replace .some() with .forEach() for confirmation checks to fix SonarCloud issue * Refactor hasMissingFields into smaller helpers to reduce cognitive complexity and improve readability * remove unused parameter from hasAcceptancePhaseMissingFields to resolve SonarCloud warning * Remove unused parameter from hasAcceptancePhaseMissingFields and update call site for clarity * remove unused utility functions * KAAV-3392 Update confirmation logic to support new data model and fix status mapping * KAAV-3120 (#624) * KAAV-3120 show current date line * KAAV-3120 force fi locale to Vis timeline * KAAV-3120 show Viikko before week number at 3 month view * KAAV-3120 weeks split on month to 2 elements do not show the whole week + number text fix * KAAV-3392 Extract status logic to independent statements for SonarCloud * KAAV-3392 remove doubled code * KAAV-1591 Fix scrolling to the top when of the form when filters change * KAAV-3025 more filter options and new styles for project edit view form filter (#628) * KAAV-3017 fix tooltip related margin-top * KAAV-3017 Prevent non-integer and negative input for floor area fields * KAAV-3017 Add fixes for SonarCloud issues * KAAV-3017 Reduce cognitive complexity * KAAV-3017 Fix negated condition * KAAV-2864 only first confirmation at current phase is required for document download * board only style fix * KAAV-3278 tarkistettu-ehodtus lautakunta-2 always disabled fix * KAAV-2590 use schema deadline required fields when checking timetable modals required values * KAAV-2590 end button to show error when confimation 1 is not true in data * KAAV-2590 added voimaantulo vaihe non required fields checks that need to be checked * KAAV-3017 refactor component to reduce cognitive complexity * KAAV-3017 Fix SonarCloud issues * KAAV-2590 find correct deadlineGroup to open from timeline error messages * KAAV-3017 add back comments that were accidentally removed * KAAV-2309 comment out icons and labels until the related features are implemented * KAAV-2247 fix issues with nahtavilla- and esillaolo past dates, move texts to translations-file, add minor style fix * KAAV-2864 Document download restriction fixes * KAAV-3120 full months names to labels, text fix for 2 years button, weekends and holidays to show up at 3month zoom lvl * KAAV-3017 remove duplicate margin-top from the styles * KAAV-3025 filters to find fields fieldset attributes * KAAV-3025 highligh fields inside fieldset * KAAV-3120 Quartest to quarter month ranges like Tammikuu - Maaliskuu when at 2 year zoom lvl * KAAV-3120 simple hover for calendar weeks * KAAV-3120 3 month zoom lvl week range hover styles and logic * KAAV-3120 3month week view to show weekend background styles correctly logic * KAAV-2590 check all confirmation fields that phase has visible when ending phase and only first one when trying to download documents * KAAV-2590 Check required deadlines and show errors, only when trying to change phase * KAAV-2590 Form error to open correct deadline data from timetable * KAAV-2590 fixes for nahtavillaolo or esillaolo linking from errors to timetable * KAAV-3120 text change for 2years view and 3month view to show holiday dates in correct slot * KAAV-2590 correct tab to be selected from timetable item when coming to view from form error link * KAAV-2590 highlight to work correctly at timetable when cliking error fields link * KAAV-3120 minor style fixes * KAAV-3120 Zoom level styles fine tuning * KAAV-3120 Zoom grid style fixes for laptops * KAAV-2590 whitescreen error when clicking error link fix, kuka esittelee lautakunnan to go lautakunta field not esillaolo from error link, Luonnos confirm fields showing up at error list links when they have not been added yeat fix. * KAAV-2590 Removed unnessacery ternary * KAAV-2590 special case checks for Voimaantulo and Hyvaksyminen phases * KAAV-2309 fixed confirmations not checked on some phases when trying to add next phase * KAAV-2207 prevent lautakunta adding after both esillaolo and lautankunta confimed on ehdotus L and XL phases * KAAV-2207 Ehdotus lautakunta confirmation checks to always check true false values too not just existance of confirmation key * KAAV-2207 adding,deleting,confirming timetable rule modifications * KAAV-2207 prevent deadline dates moving from calendar to past from today, when adding new phase and old phase is far in the past, move new dates alway to future * KAAV-2207 phase list XL to contain periaatteet and luonnos phases only if attributeData has them added to project logic * KAAV-2207 XL periaatteet and luonnos lautakunta deleted to 0 needs to be able to be added again logic * KAAV-2207 Prevent adding esillaolo/nahtavillaolo if lautakunta has been added and confirmed. Exception for XL/L ehdotus phase where lautakunta comes before esillaolo * KAAV-2207 confirmation info logic modifications * KAAV-2207 Periaatteet missing past esillaolo check added * KAAV-2207 lautakuntainpast fixes, lautakunta confirm options not checked correctly fix * sonarcloud fixx * KAAV-2207 added safeguard logic for past and confirmed dates not to move when adding or moving other elements, only exception if the distances are incorrectly set from Django etc * clenead some comments * KAAV-2207 if any past lautakunta is confirmed do not allow confirmation cancel to esillaolo except in ehdotus L/XL phases other way round if any past nahtavillaolo confirmed then do not allow cancel for lautakunta confirmation. * KAAV-2207 added exceptions for lautakunta checks when removing first phases from luonnos or periaatteet phase. * KAAV-2207 deleting and adding to keep data up to date on refux form, past elements on timeline cannot be confirmed fix, empty tab on timeline side panel if switching from lautakunta to esillaolo fix, fixed incorrect reason message * KAAV-2207 removed not needed ternary * KAAV-2207 remove false flag that prevents adding esillaolo for periaatteet and luonnos when any other phase is ongoing * KAAV-2207 prevent Ehdotus L/XL phase nahtavillaolo confirmation before lautakunta * KAAV-2207 nahtavillaolo phase keys were missing from adjustDeadlineData and the latest key replaces older ones so phase 2 was missing after phase 3 * removed console.log * KAAV-2207 removed safeguard logic for now * removed initialization code and testing validation slowness * KAAV-2207 fixed XL/L ehdotus phase nahtavillaolo could be confirmed before lautakunta2 confirmed * KAAV-2207 wrong texts on states * KAAV-2207 fixes * KAAV-2207 wrong cannot add reason message for esillaolo when periaatteet/luonnos lautakunta is confirmed * KAAV-2207 update to lautakunta confirm code * KAAV-2207 esillaolo add logic fix * KAAV-3476 allow deleting XL ehdotus first lautakunta and re-adding it (#637) * KAAV-3475 end phase button does nothing before pressing check errors button fix (#638) * update time and relative date text next to field, header error and success update date field modification * styles and saving icon to same spot where time is shown * network error component and states checking first draft * error status components to fields and listening to save and network states * KAAV-3260 networdState component implmentation to all intended components * KAAV-3260 loading spinners removed from edit components and moved to higher order in time, info header bar of component, logic from invividual components moved to global redux solution * KAAV-3260 added HDS number component and modified logic for it, blur styles, fixed logic flaws * removed duplicate variable * KAAV-3260 refactored duplications to own helper * KAAV-3260 style modifications * KAAV-3260 removed previously removed functions function call that gave error at Select and Link components, File/image did not show loading icon and time fix, radiobutton component and number input were editable when saving and components styles were disabled fix, translation fixes, replaced HDS dialog with custom dialog because HDS opening and closing position for dialog was a mess. * KAAV-3260 missing x button from dialog, sonarcloud fixes * KAAV-3260 sonarcloud fix * KAAV-3260 fieldset loading spinner to showup on correct sub fieldset field and also to top fieldset * KAAV-3260 slight tweak for fieldset modification * KAAV-3260 accept minus numbers on type number inputs on edit form * KAAV-3260 Fieldset sub fields to show last modified info too * KAAV-3260 Select fields to be disabled when they are saving * KAAV-3260 input selectable fix * KAAV-3260 remove updated time from fieldset sub field because i cannot be at the moment shown separately. Shows always the same update time as the whole fieldset update time. * KAAV-3260 file and link to be disabled when saving * KAAV-3260 prevent multi select tag to be deleted when saving --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Minna Honkanen <159889008+MinnaSiili@users.noreply.github.com> Co-authored-by: Minna Honkanen <minna.honkanen@siili.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eemeli Kukkonen <eemeli.kukkonen@siili.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.