Skip to content

Comments

Replace Webpack server with Vite KER-404#1093

Merged
mikkojamG merged 2 commits intomainfrom
feat/KER-404-vite
Apr 8, 2025
Merged

Replace Webpack server with Vite KER-404#1093
mikkojamG merged 2 commits intomainfrom
feat/KER-404-vite

Conversation

@mikkojamG
Copy link
Contributor

@mikkojamG mikkojamG commented Nov 5, 2024 •
edited
Loading

Replacing old Webpack server solution with Vite.

  • Replace Jest with Vitest
  • Update runtime envs with a script
  • Replace old toml configuration files with .env
  • Remove multiple unneeded dependencies

Requires changes to UI config map: https://dev.azure.com/City-of-Helsinki/kerrokantasi/_git/kerrokantasi-pipelines/pullrequest/9987

Fixes multiple vulnerabilities:

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@mikkojamG mikkojamG changed the title [DRAFT] feat: remove webpack, add Vite and Vitest KER-404 [DRAFT] Replace Webpack server with Vite KER-404 Nov 6, 2024
@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 6, 2024

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 7, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 7, 2024

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 7, 2024

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 7, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@mikkojamG mikkojamG force-pushed the feat/KER-404-vite branch 2 times, most recently from 23c9f73 to 02fa76e Compare November 7, 2024 08:53
@mikkojamG mikkojamG changed the title [DRAFT] Replace Webpack server with Vite KER-404 Replace Webpack server with Vite KER-404 Nov 7, 2024
@mikkojamG mikkojamG marked this pull request as ready for review November 7, 2024 08:58
@mikkojamG mikkojamG requested review from a team and arpargo November 7, 2024 08:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 7, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Nov 7, 2024

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

arpargo
arpargo previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@arpargo arpargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terovirtanen
Copy link
Contributor

terovirtanen commented Dec 17, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Dec 17, 2024

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

terovirtanen commented Dec 19, 2024

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Mar 14, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Mar 14, 2025

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

terovirtanen commented Mar 31, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Mar 31, 2025

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG force-pushed the feat/KER-404-vite branch from 20b068e to 9548061 Compare April 7, 2025 06:58
@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 7, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 7, 2025

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG force-pushed the feat/KER-404-vite branch 2 times, most recently from 4a1e6eb to 7659d04 Compare April 7, 2025 12:20
@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 7, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 7, 2025

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

arpargo
arpargo previously approved these changes Apr 8, 2025
View reviewed changes
@mikkojamG mikkojamG force-pushed the feat/KER-404-vite branch from cf9baf9 to c138f9a Compare April 8, 2025 11:02
@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 8, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 8, 2025

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 8, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

2 similar comments
@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 8, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 8, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@mikkojamG mikkojamG force-pushed the feat/KER-404-vite branch from c6a5e08 to 4202a87 Compare April 8, 2025 12:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 8, 2025

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

terovirtanen commented Apr 8, 2025

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG merged commit cf7e8a9 into main Apr 8, 2025
22 of 23 checks passed
@mikkojamG mikkojamG deleted the feat/KER-404-vite branch April 8, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arpargo arpargo arpargo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikkojamG @terovirtanen @arpargo